Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show reasonable rate when t is 0 #790

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

tkbky
Copy link
Contributor

@tkbky tkbky commented Oct 2, 2018

As reported in #789 , when running an empty test, the rate for data_received, data_sent and iterations are unexpectedly huge. It happens when the execution time t is 0.

This change fixes that by setting the rate to 0 when t is 0, which is reasonable.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #790 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage    63.9%   63.89%   -0.02%     
==========================================
  Files         102      102              
  Lines        8498     8500       +2     
==========================================
  Hits         5431     5431              
- Misses       2706     2708       +2     
  Partials      361      361
Impacted Files Coverage Δ
ui/summary.go 17.7% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d0d2e...9265e51. Read the comment docs.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@mstoykov mstoykov merged commit 0904b2c into grafana:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants