-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crypto.randomBytes #922
Conversation
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
+ Coverage 69.77% 69.82% +0.05%
==========================================
Files 112 112
Lines 8815 8823 +8
==========================================
+ Hits 6151 6161 +10
+ Misses 2262 2261 -1
+ Partials 402 401 -1
Continue to review full report at Codecov.
|
AppVeyor failed on this, but it seems to be from a different part of the code. I don't think it's from the changes:
|
Codecov is showing 95.72%, but running locally I get 96.1%. Is it possible it doesn't rerun if the CI builds fail? |
LGTM! |
Should I be updating the copyright date on files I modify? It's a couple years old now. |
I am pretty sure we should make some script or use some tool to update this automatically ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for merging guys. |
Adds method
randomBytes
tok6/crypto
. The method takes a single parametersize
specifying byte count and returns an array of random bytes. Bytes are represented as number literals.Toward #900.