Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary outputEncoding to the crypto functions #952

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

mstoykov
Copy link
Contributor

this commit also add crypto.hexEncode which given byte array something
that looks like it will return a string with the value of the array in
hex

this commit also add crypto.hexEncode which given byte array something
that looks like it will return a string with the value of the array in
hex
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #952 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   70.72%   70.73%   +<.01%     
==========================================
  Files         121      121              
  Lines        9188     9191       +3     
==========================================
+ Hits         6498     6501       +3     
  Misses       2283     2283              
  Partials      407      407
Impacted Files Coverage Δ
js/modules/k6/crypto/crypto.go 97.54% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8bccc...a570d30. Read the comment docs.

@na-- na-- changed the title Add binary outputEncoding to crypto function and make it default Add binary outputEncoding to the crypto functions Mar 14, 2019
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@robingustafsson robingustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstoykov mstoykov merged commit 2486f68 into master Mar 14, 2019
@mstoykov mstoykov deleted the feature/AddBinaryOutputForCrypto branch March 14, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants