-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable console in the init context #982
Conversation
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 72.12% 72.12% +<.01%
==========================================
Files 131 131
Lines 9621 9622 +1
==========================================
+ Hits 6939 6940 +1
Misses 2268 2268
Partials 414 414
Continue to review full report at Codecov.
|
This commit does the bare minimal to enable useage of console init context. Unfortunetely this means that redirection to file is currently not supported in init context.
802f615
to
570fc36
Compare
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 73.28% 73.28% +<.01%
==========================================
Files 141 141
Lines 10287 10288 +1
==========================================
+ Hits 7539 7540 +1
Misses 2304 2304
Partials 444 444
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in #951 (comment), it'd be fine with merging this as it is for now, despite the known incompatibility with --console-output
. But before merging it, we should create a new issue that describes this bug, linking to this PR and the original issue. And we should mention it in a Known bugs section in the release notes, so add that to the PR description please.
This commit does the bare minimal to enable useage of console init
context. Unfortunetely this means that redirection to file is currently
not supported in init context.
This fixes #951
Message for the release notes: