Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support negative numbers in LogQL #61

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat: Support negative numbers in LogQL #61

merged 2 commits into from
Jun 4, 2024

Conversation

matyax
Copy link
Contributor

@matyax matyax commented Jun 3, 2024 •
edited
Loading

Mirrors grafana/loki#13091

Adds negative number support to the LogQL parser.

  • Works for both ints and floats.
  • Negative durations are already supported.
  • Negative bytes are not supported because the humanize library does not support them

Tree

@matyax matyax self-assigned this Jun 3, 2024
ivanahuckova
ivanahuckova approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ivanahuckova
Copy link
Member

@matyax do you want to wait with this until grafana/loki#13091 is merged, as this is currently not supported by loki.

@matyax
Copy link
Contributor Author

matyax commented Jun 4, 2024

grafana/loki#13091 merged

@matyax matyax merged commit 42f4fa2 into main Jun 4, 2024
2 checks passed
@matyax matyax mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@svennergr svennergr Awaiting requested review from svennergr

@gtk-grafana gtk-grafana Awaiting requested review from gtk-grafana

Assignees

@matyax matyax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matyax @ivanahuckova