Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k176] Propagate trace ID with HTTP gRPC request. #11270

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

grafanabot
Copy link
Collaborator

Backport 8d34f85 from #11251


What this PR does / why we need it:
The changes in #10688 did not propage the trace ID from the context. Frontend.RoundTripGRPC would inject the trace ID into the request. That's not done in Frontend.Do. This changes extends the codec.EncodeRequest to inject the trace ID there. This is more inline with other metadata.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

The changes in #10688 did not
propage the trace ID from the context. `Frontend.RoundTripGRPC` would
inject the trace ID into the request. That's not done in `Frontend.Do`.
This changes extends the `codec.EncodeRequest` to inject the trace ID
there. This is more inline with other metadata.

(cherry picked from commit 8d34f85)
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

Trivy scan found the following vulnerabilities:

@trevorwhitney trevorwhitney merged commit f9c1ef3 into k176 Nov 20, 2023
13 checks passed
@trevorwhitney trevorwhitney deleted the backport-11251-to-k176 branch November 20, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants