fix: support multi-zone ingesters when converting global to local limits for streams in limiter.go #13321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or streams in limiter.go Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
JordanRushing
changed the title
vlad-diachenko
approved these changes
Jun 26, 2024
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
…limit test; go mod vendor & go mod tidy Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
vlad-diachenko
approved these changes
Jun 27, 2024
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
This was referenced Jul 8, 2024
JordanRushing
added a commit
to JordanRushing/loki
that referenced
this pull request
Jul 15, 2024
Ingester stream limits now take into account "owned streams" and periodically update when the Ingester ring is changed. Non-owned streams are now also flushed when this update takes place. The stream limit calculation has also been updated for improved accuracy in multi-zone ingester deployments. Relevant PRs: - grafana#13006 - grafana#13030 - grafana#13232 - grafana#13103 - grafana#13231 - grafana#13254 - grafana#13314 - grafana#13321
7 tasks
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the calculation for stream limits to support multi-zone ingester deployments while maintaining the old logic for single-zone deployments.
re:
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Requires grafana/dskit#526 to be merged and the version of dskit used by Loki to be updated to support
HealthyInstancesInZoneCount()Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR