feat(operator): Add alert for discarded samples #13512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds an alert to the set of alerts provided by the operator, that fires when there are samples discarded by Loki during ingestion. It should only alert on non-retryable errors.
Which issue(s) this PR fixes:
Fixes LOG-5731
Special notes for your reviewer:
The threshold for alerting is currently set to "zero". This means that the alert will fire if any samples are discarded. I don't think we can do an alerting based on percentage here (because I do not see a metric for "accepted samples") or if it makes any sense.
I'm looking into extending the unit-tests we have for alerts to also cover this alert.
Checklist
CONTRIBUTING.md
guide (required)