Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WAL Manager configuration options #13531

Merged
merged 1 commit into from
Jul 16, 2024
Merged

feat: WAL Manager configuration options #13531

merged 1 commit into from
Jul 16, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Jul 15, 2024 •
edited
Loading

What this PR does / why we need it:

This commit adds support for configuring the WAL Manager with CLI flags.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana
WAL Manager configuration options
9c7a72b 
This commit adds support for configuring the WAL Manager with CLI
flags.
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner July 15, 2024 16:29
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 15, 2024
@grobinson-grafana grobinson-grafana changed the title WAL Manager configuration options feat: WAL Manager configuration options Jul 15, 2024
JStickler
JStickler reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Docs updates LGTM

@grobinson-grafana grobinson-grafana merged commit c4405fe into main Jul 16, 2024
62 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/wal-manager-configuration-options branch July 16, 2024 09:01
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
This was referenced Aug 15, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler left review comments

@benclive benclive benclive approved these changes

Assignees
No one assigned
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grobinson-grafana @JStickler @benclive