Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k212] fix: remove retries on the stats handlers because they already retry #13610

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 1008315 from #13608


What this PR does / why we need it:

#13584 added retries to the stats handlers because I had seen some 5xx errors on stats functions not being retried. it was pointed out we already have retries on the statshandler, the tripperware used here already includes it.

Instead it seems the 5xx's that were not retried were fixed in #13592 so this PR removes the duplicate retry

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

…13608)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
(cherry picked from commit 1008315)
@grafanabot grafanabot requested a review from a team as a code owner July 22, 2024 12:27
@grafanabot grafanabot added backport size/XS type/bug Somehing is not working as expected labels Jul 22, 2024
@slim-bean slim-bean merged commit b8e16b6 into k212 Jul 22, 2024
61 of 62 checks passed
@slim-bean slim-bean deleted the backport-13608-to-k212 branch July 22, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants