fix(helm): align image pull secrets usage #13635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure seems to be due to #13633 ? |
|
Thanks, I'll rebase and adjust the changelog/chart |
sebhoss
force-pushed
the
pull-secret-alignment
branch
from
c9fc02d
to
97c1dca
Compare
|
@JStickler I think this is good to go now & sorry for the delay! |
sebhoss
force-pushed
the
pull-secret-alignment
branch
from
97c1dca
to
3bf5e95
Compare
|
Rebased on latest main |
|
The test failure in |
sebhoss
force-pushed
the
pull-secret-alignment
branch
from
3bf5e95
to
2c6427d
Compare
|
Rebased on latest main |
Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
sebhoss
force-pushed
the
pull-secret-alignment
branch
from
2c6427d
to
5e4e2ff
Compare
|
rebased on latest main |
|
@JStickler & @MasslessParticle can you take another look? |
|
OK thanks - fixed with #13788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes that users specify pull secrets like this in their values.yaml:
Most workloads in this helm chart already expect this to happen anyway. Those workloads that did not expect this were changed to keep the number of user facing breaking changes minimal.
What this PR does / why we need it:
The helm chart is currently inconsistent wrt. its usage of pull secrets. Sometimes it expects just an array of strings, sometimes a list of maps. This change alignes every pull secret reference to expect a list of maps. This was chosen because most workloads already expected this format and it is more future proof(tm) if https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/local-object-reference/#LocalObjectReference ever changes.
Which issue(s) this PR fixes:
This fixes an issue introduced with #13051 (comment) and extends what has happened in #13761
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR