Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixins / loki-resources-overview panel layout #14178

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Sep 19, 2024

What this PR does / why we need it:

This PR fixes a layout issue brought up here #13471 (comment)

This now renders as such which is a whole lot better :)

image

The multi-row approach was taken from the mimir resource overview dashboards

cc @cstyan

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@QuentinBisson QuentinBisson force-pushed the fix-grid-infos-in-loki-resources-overview-mixin branch from 887d57e to 2f902b4 Compare September 19, 2024 09:02
@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 19, 2024
@QuentinBisson QuentinBisson changed the title fix: mixins / grid pos in loki-resources-overview fix: mixins / loki-resources-overview panel layout Sep 19, 2024
@QuentinBisson QuentinBisson marked this pull request as ready for review September 19, 2024 12:33
@QuentinBisson QuentinBisson requested a review from a team as a code owner September 19, 2024 12:33
@cstyan
Copy link
Contributor

cstyan commented Sep 19, 2024

@QuentinBisson thanks for your continued work on the mixin 👍

@cstyan cstyan merged commit 8f54ec6 into grafana:main Sep 19, 2024
61 checks passed
@QuentinBisson
Copy link
Contributor Author

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants