Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [release-3.2.x] fix: Add additional validation for timeout while retrieving headers #14220

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Sep 23, 2024

Backport 8322e51 from #14217


What this PR does / why we need it:
Go 1.23 changed the type of error being returned in the case of a timeout while waiting for headers, as documented in this issue
Which issue(s) this PR fixes:
Fixes #14206

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner September 23, 2024 13:32
@loki-gh-app loki-gh-app bot added backport size/XS type/bug Somehing is not working as expected labels Sep 23, 2024
@loki-gh-app loki-gh-app bot requested a review from paul1r September 23, 2024 13:33
@paul1r paul1r merged commit d96feac into release-3.2.x Sep 23, 2024
59 of 63 checks passed
@paul1r paul1r deleted the backport-14217-to-release-3.2.x branch September 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant