Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage/bloom/v1): bind bloom page size to max bloom size #14372

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Oct 3, 2024

What this PR does / why we need it:
Previously, the bloom page size was hard-coded to 256KB. However, 256KB is much smaller than the normal bloom size, leading to nearly every bloom page to be overfilled with a single, massive bloom.

Binding the bloom page size to the maximum bloom size allows bloom pages to contain multiple smaller blooms (which are still larger than 256KB) or one maxed out bloom.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@rfratto rfratto requested a review from a team as a code owner October 3, 2024 13:01
Previously, the bloom page size was hard-coded to 256KB. However, 256KB
is much smaller than the normal bloom size, leading to nearly every
bloom page to be overfilled with a single, massive bloom.

Binding the bloom page size to the maximum bloom size allows bloom pages
to contain multiple smaller blooms (which are still larger than 256KB)
or one maxed out bloom.

Signed-off-by: Robert Fratto <robertfratto@gmail.com>
@rfratto rfratto merged commit e9efcb5 into grafana:main Oct 3, 2024
60 checks passed
@rfratto rfratto deleted the update-bloom-page-size branch October 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants