feat(thanos): make use of the new function IterWithAttributes #14793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| err := o.bucket.Iter(ctx, prefix, func(objectKey string) error { | ||
| err := o.bucket.IterWithAttributes(ctx, prefix, func(attrs objstore.IterObjectAttributes) error { |
There was a problem hiding this comment.
let's also check if the provider supports UpdatedAt option, if not we should make a follow-up Attributes call to fetch it given the callers of List might use the ModifiedAt field
| attr, err := o.bucket.Attributes(ctx, objectKey) | ||
| if err != nil { | ||
| return errors.Wrapf(err, "failed to get attributes for %s", objectKey) | ||
| lastModified, ok := attrs.LastModified() |
There was a problem hiding this comment.
i think we should fail if lastModified is not set, callers of List might expect this to be set
| } | ||
|
|
||
| err := o.bucket.Iter(ctx, prefix, func(objectKey string) error { | ||
| supportUpdatedAt := objstore.ValidateIterOptions(o.bucket.SupportedIterOptions(), objstore.WithUpdatedAt()) == nil |
There was a problem hiding this comment.
i don't like how this validation method turned out 😓 i think alternatively we could use
slices.Contains(o.bucket.SupportedIterOptions(), objstore.UpdatedAt)
| } | ||
|
|
||
| err := o.bucket.Iter(ctx, prefix, func(objectKey string) error { | ||
| supportUpdatedAt := objstore.ValidateIterOptions(o.bucket.SupportedIterOptions(), objstore.WithUpdatedAt()) == nil |
There was a problem hiding this comment.
Suggested change
| supportUpdatedAt := objstore.ValidateIterOptions(o.bucket.SupportedIterOptions(), objstore.WithUpdatedAt()) == nil | |
| supportsUpdatedAt := objstore.ValidateIterOptions(o.bucket.SupportedIterOptions(), objstore.WithUpdatedAt()) == nil |
ashwanthgoli
approved these changes
Nov 11, 2024
ashwanthgoli
pushed a commit
that referenced
this pull request
Nov 12, 2024
6 tasks
trevorwhitney
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With thanos-io/objstore#63 we now don't need to make an extra call to get the Attributes
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR