-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thanos): disable retries when congestion control is enabled #14867
Conversation
@@ -37,19 +66,14 @@ func NewObjectClientAdapter(bucket, hedgedBucket objstore.Bucket, logger log.Log | |||
}, | |||
} | |||
|
|||
for _, opt := range opts { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC we are removing this because we removed the ClientOptions right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. It was being used to apply retry strategy from the provider specific adapters, but that bit is moved to the init func
Hello @ashwanthgoli!
Please, if the current pull request addresses a bug fix, label it with the |
This PR must be merged before a backport PR will be created. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14867-to-k228 origin/k228
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 947a66f35e1e02505290f52f2eee17c3e281cbbc When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14867-to-k228
# Create the PR body template
PR_BODY=$(gh pr view 14867 --json body --template 'Backport 947a66f35e1e02505290f52f2eee17c3e281cbbc from #14867{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'feat(thanos): disable retries when congestion control is enabled (backport k228)' --body-file - --label 'size/L' --label 'product-approved' --label 'backport' --base k228 --milestone k228 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14867-to-k228
# Create a pull request where the `base` branch is `k228` and the `compare`/`head` branch is `backport-14867-to-k228`.
# Remove the local backport branch
git switch main
git branch -D backport-14867-to-k228 |
What this PR does / why we need it:
Configures max retries to 1 to disable retries when congestion control is enabled. Plus some refactoring to reduce duplicate code coming from provider specific adapters
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR