feat: add per-tenant time sharding for long out-of-order ingestion (backport release-3.3.x) #15482
+413
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
JoaoBraveCoding
approved these changes
Dec 18, 2024
JStickler
reviewed
Dec 18, 2024
| @@ -3723,6 +3723,18 @@ shard_streams: | |||
| # CLI flag: -shard-streams.enabled | |||
| [enabled: <boolean> | default = true] | |||
|
|
|||
| # Automatically shard streams by adding a __time_shard__ label, with values | |||
| # calculated from the log timestamps divided by MaxChunkAge/2. This allows the | |||
| # out-of-order ingestion of very old logs. If both flags are enabled, | |||
There was a problem hiding this comment.
When this says "Both flags" I'm unclear on what the other flag is. Could you please name it to avoid confusion.
There was a problem hiding this comment.
The time-sharding feature depends on the stream-sharding to be enabled (directly above in this view). While I agree that this is a bit intransparent in how it is currently worded, I don't think we should change the text in the backport. This change should be introduced into main first, to avoid reverting back to the old text in the future.
There was a problem hiding this comment.
I didn't notice that this was a backport. I agree, the change should be made in main.
xperimental
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a backport of #14711 to
release-3.3.x.Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)