Dns config support with Simple Scaleable Mode #15537
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
TPL function causes the DNSconfig to be a string instead it is object as per kubernetes pod spec.
Ref: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Before this PR
$ helm template grafana/loki -f grafana-loki.yaml --debug install.go:218: [debug] Original chart version: "" install.go:235: [debug] CHART PATH: /home/pox/.cache/helm/repository/loki-6.24.0.tgz Error: template: loki/templates/write/statefulset-write.yaml:154:16: executing "loki/templates/write/statefulset-write.yaml" at <.>: wrong type for value; expected string; got map[string]interface {} helm.go:84: [debug] template: loki/templates/write/statefulset-write.yaml:154:16: executing "loki/templates/write/statefulset-write.yaml" at <.>: wrong type for value; expected string; got map[string]interface {}
After PR*