Skip to content

Commit

Permalink
Remove other uses of AllowAutoTopicCreation
Browse files Browse the repository at this point in the history
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
  • Loading branch information
dimitarvdimitrov committed Dec 4, 2024
1 parent 9fd6bdb commit 8a8e827
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ lint: check-makefiles
# As a result the topic can be created with the wrong number of partitions.
faillint -paths \
"github.com/twmb/franz-go/pkg/kgo.{AllowAutoTopicCreation}" \
./pkg/... ./cmd/... ./integration/...
./pkg/... ./cmd/... ./tools/... ./integration/...

format: ## Run gofmt and goimports.
find . $(DONT_FIND) -name '*.pb.go' -prune -o -type f -name '*.go' -exec gofmt -w -s {} \;
Expand Down
1 change: 0 additions & 1 deletion pkg/blockbuilder/kafkautil_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ func TestKafkaMarshallingCommitMeta(t *testing.T) {
func mustKafkaClient(t *testing.T, addrs ...string) *kgo.Client {
writeClient, err := kgo.NewClient(
kgo.SeedBrokers(addrs...),
kgo.AllowAutoTopicCreation(),
// We will choose the partition of each record.
kgo.RecordPartitioner(kgo.ManualPartitioner()),
)
Expand Down
1 change: 0 additions & 1 deletion pkg/blockbuilder/scheduler/scheduler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
func mustKafkaClient(t *testing.T, addrs ...string) *kgo.Client {
writeClient, err := kgo.NewClient(
kgo.SeedBrokers(addrs...),
kgo.AllowAutoTopicCreation(),
// We will choose the partition of each record.
kgo.RecordPartitioner(kgo.ManualPartitioner()),
)
Expand Down
1 change: 0 additions & 1 deletion tools/kafkatool/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ func CreateKafkaClient(kafkaAddress, kafkaClientID string, auth sasl.Mechanism)
kgo.ClientID(kafkaClientID),
kgo.RecordPartitioner(kgo.ManualPartitioner()),
kgo.DisableIdempotentWrite(),
kgo.AllowAutoTopicCreation(),
kgo.BrokerMaxWriteBytes(268_435_456),
kgo.MaxBufferedBytes(268_435_456),
}
Expand Down

0 comments on commit 8a8e827

Please sign in to comment.