Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: set unlimited max concurrency in PromQL engine #1298

Closed
pracucci opened this issue Feb 24, 2022 · 0 comments · Fixed by #2598
Closed

Proposal: set unlimited max concurrency in PromQL engine #1298

pracucci opened this issue Feb 24, 2022 · 0 comments · Fixed by #2598

Comments

@pracucci
Copy link
Collaborator

While working on the query-scheduler documentation (PR) we realised it's quite complex to understand the implications of running a number of query-frontend / query-scheduler replicas higher than -querier.max-concurrent.

Given we assume a Grafana Mimir cluster always run with the query-frontend and given the max concurrency per querier is enforced by the number of running workers (because each worker can only execute 1 query at a time), we could simply configure the PromQL max concurrency to "unlimited".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant