-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set unlimited max concurrency in PromQL engine #2598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustin170506
force-pushed
the
rustin-patch-querier
branch
from
August 2, 2022 12:57
6b5b0c7
to
5b62c8f
Compare
@pracucci Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️ |
pracucci
reviewed
Aug 8, 2022
Rustin170506
force-pushed
the
rustin-patch-querier
branch
from
August 19, 2022 12:54
5b62c8f
to
b2e9159
Compare
Rustin170506
requested review from
pracucci
and removed request for
dimitarvdimitrov
August 19, 2022 12:59
pracucci
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left few final suggestion I'm just going to self-apply.
docs/sources/operators-guide/architecture/components/query-frontend/index.md
Outdated
Show resolved
Hide resolved
docs/sources/operators-guide/architecture/components/query-frontend/index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Thanks for your review! 💚 💙 💜 💛 ❤️ |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Set unlimited max concurrency in PromQL engine and update test.
Which issue(s) this PR fixes or relates to
Fixes #1298
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]