Enforce max series limit in the distributor when usage-tracker is enabled #10129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
colega
reviewed
Dec 4, 2024
Comment on lines
+1228
to
+1233
| if len(rejectedHashes) > 0 { | ||
| // Build a map of rejected hashes so that it's easier to lookup. | ||
| rejectedHashesMap := make(map[uint64]struct{}, len(rejectedHashes)) | ||
| for _, hash := range rejectedHashes { | ||
| rejectedHashesMap[hash] = struct{}{} | ||
| } |
There was a problem hiding this comment.
Lets see if this causes issues, we might want to return rejected indexes instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Enforce max series limit in the distributor when usage-tracker is enabled. I left few TODOs that I don't plan to address in the prototype, but would be required if we'll move forward productionising it.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.