UsageTracker: process created series events #10132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
approved these changes
Dec 5, 2024
| // processCreatedSeriesEvent creates the series coming from an event from Kafka, | ||
| // i.e. series that were created by a different instance. | ||
| // This does not check the limits, as we prioritize staying consistent across replicas over enforcing limits. | ||
| // Timestamp is not updated if series exists already. |
There was a problem hiding this comment.
Shouldn't be updated with the highest value between the two? I guess it shouldn't happen, but never know.
There was a problem hiding this comment.
It could happen but we don't really care as we'll update when we process the snapshot later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to process series creation events, also a test that checks that it's compatible with the events produced.