-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to gopkg.in/yaml.v3
#2468
Commits on Jul 19, 2022
-
Use gopkg.in/yaml.v3 everywhere
This replaces all usages of gopkg.in/yaml.v2 by v3 everywhere, adapts the UnmarshalYAML methods to the new signature, and replaces the UnmarshalStrict calls by the decoder with KnownFields flag. util.YAMLMarshalUnmarshal doesn't work because it doesn't support unmarshaling map[interface{}]interface{} Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for 5e3f298 - Browse repository at this point
Copy the full SHA 5e3f298View commit details -
yaml.v3 can't unmarshal to map[interface{}]interface{}, but actually map[string]interface{} should be enough. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for b90775a - Browse repository at this point
Copy the full SHA b90775aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7b8102 - Browse repository at this point
Copy the full SHA e7b8102View commit details -
Add faillint for gopkg.in/yaml.v2
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for c46e7b1 - Browse repository at this point
Copy the full SHA c46e7b1View commit details
Commits on Jul 20, 2022
-
Use custom fork of gopkg.in/yaml.v3
This commit is the latest v3 with go-yaml/yaml#691 cherry-picked on top of it, to provide support for strict unmarshaling when doing custom unmarshaling (see go-yaml/yaml#460) Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for e0fa9fc - Browse repository at this point
Copy the full SHA e0fa9fcView commit details -
Fix TestAlertmanagerNotificationLimitsOverrides
There's no such field as `alertmanager_notification_limits_per_integration` and the fixed strict parsing has detected this. How does this test pass in `main`? Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for 53d4a65 - Browse repository at this point
Copy the full SHA 53d4a65View commit details -
Remove cfg.validateYAMLEmptyNodes and adapt test
gopkg.in/yaml.v3 implementation doesn't seem to set the entire value to zero value if an empty node is specified in the YAML. So we don't need that check again, and we can adapt the test just to check that this assertion is true. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Configuration menu - View commit details
-
Copy full SHA for e41127b - Browse repository at this point
Copy the full SHA e41127bView commit details