Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user label to ingester out-of-order appended samples metric #2493

Merged

Conversation

jesusvazquez
Copy link
Member

What this PR does

Adds tenant label to cortex_ingester_tsdb_out_of_order_samples_appended_total.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

To easily identify if a tenant is receiving out of orer samples, we've
added a user label to the counter metric that counts them.
@jesusvazquez jesusvazquez self-assigned this Jul 20, 2022
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We try to keep the number of per-tenant metrics as lowest as possible, but I 💯 understand the value of having this metric on a per-tenant basis.

@jesusvazquez jesusvazquez marked this pull request as ready for review July 21, 2022 09:03
@pracucci pracucci merged commit 96904e2 into main Jul 21, 2022
@pracucci pracucci deleted the jvp/add-tenant-dimension-to-appended-ooo-samples-metric branch July 21, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants