-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimir-continuous-test tool: Add basic authentication support #2717
mimir-continuous-test tool: Add basic authentication support #2717
Conversation
7f3d597
to
86974f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one change. Thanks!
… support Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
86974f3
to
642ec76
Compare
I've also added the support for bearer token to fully address #2105 |
Thanks! |
@wilfriedroset I have a question! How does reverse proxy work when authenticating with a bearer token, does this mean mimir doesn't do the auth but the proxy does instead? I've seen the configs in the docs, but havent been able to find an explanation on how it actually works. Thank you! |
Mimir does not handle authentication by itself. This part is delegated to an eventual proxy placed before Mimir. It can be as simple as a basic auth in nginx something like:
Where x_scope_orgid is define as a map in nginx configuration
|
Thanks @wilfriedroset for the explanation! How about when it comes to |
The proxy (at least for nginx) does not do anything about the external labels. They are used by mimir during the deduplication process. You can find out more in the documentation: https://grafana.com/docs/mimir/latest/operators-guide/configure/configuring-high-availability-deduplication/ |
What this PR does
Added basic authentication support to mimir-continuous-testing for when Mimir is behind a gateway authenticating the calls.
Which issue(s) this PR fixes or relates to
Fixes #2105
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]