Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blocks-storage.tsdb.isolation-enabled option. #2782

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

pstibrany
Copy link
Member

What this PR does

This PR removes -blocks-storage.tsdb.isolation-enabled option, which defaulted to false. For rationale see #1655.

Checklist

  • [na] Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add a CHANGELOG entry. We previously announced the deprecation, now we should mention the removal.

@pstibrany
Copy link
Member Author

LGTM but please add a CHANGELOG entry. We previously announced the deprecation, now we should mention the removal.

There is a changelog entry, right? 🤔

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@pracucci pracucci merged commit bf01808 into main Aug 22, 2022
@pracucci pracucci deleted the remove-isolation-option branch August 22, 2022 07:19
@grafanabot
Copy link
Contributor

The backport to release-2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-2782-to-release-2.3 origin/release-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x bf018089f2c8c5f31b483c056494b9e24606bc48
# Push it to GitHub
git push --set-upstream origin backport-2782-to-release-2.3
git switch main
# Remove the local backport branch
git branch -D backport-2782-to-release-2.3

Then, create a pull request where the base branch is release-2.3 and the compare/head branch is backport-2782-to-release-2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants