Introduce single forward endpoint to simplify configuration. #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
replay
reviewed
Aug 23, 2022
| defer closeFn() | ||
|
|
||
| rules := validation.ForwardingRules{ | ||
| "metric1": validation.ForwardingRule{Ingest: false}, |
There was a problem hiding this comment.
How about we make one rule specify an invalid forwarding target, to check that it gets overridden by the one passed into Forward()?
Suggested change
| "metric1": validation.ForwardingRule{Ingest: false}, | |
| "metric1": validation.ForwardingRule{Ingest: false, Endpoint: "invalid"}, |
replay
approved these changes
Aug 23, 2022
…ot used. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pracucci
reviewed
Aug 24, 2022
| @@ -159,7 +160,8 @@ type Limits struct { | |||
| AlertmanagerMaxAlertsCount int `yaml:"alertmanager_max_alerts_count" json:"alertmanager_max_alerts_count"` | |||
| AlertmanagerMaxAlertsSizeBytes int `yaml:"alertmanager_max_alerts_size_bytes" json:"alertmanager_max_alerts_size_bytes"` | |||
|
|
|||
| ForwardingRules ForwardingRules `yaml:"forwarding_rules" json:"forwarding_rules" doc:"nocli|description=Rules based on which the Distributor decides whether a metric should be forwarded to an alternative remote_write API endpoint."` | |||
| ForwardingEndpoint string `yaml:"forwarding_endpoint" json:"forwarding_endpoint" doc:"nocli|description=Remote-write endpoint where metrics specified in forwarding_rules are forwarded to. If set, takes precedence over endpoints specified in forwarding rules."` | |||
There was a problem hiding this comment.
At this point we're moving it from per-rule to per-tenant, hence nocli. But I agree that it could be useful to set it globally too in some situations. Let's tackle that when we remove per-rule endpoints.
(nocli doesn't prevent this to be used globally via config file of course)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds
forwarding_endpointto per-tenant limits, which takes precedence over forwarding-rule-specific endpoints. Endpoints in forwarding rules will be removed next.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]