-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track OOO setting via anonymous usage statistics #2940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR lgtm, but I would suggest to wait with merge until release-2.3 branch is merged to main
, and rebase this PR first. This PR should not modify changelog entry for feature from 2.3 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding this @pracucci !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Marco Pracucci <marco@pracucci.com>
5b735ca
to
c8ec036
Compare
What this PR does
As requested by @jesusvazquez, in this PR I'm adding the tracking of the number of tenants with OOO ingestion enabled, and their min and max time window setting.
The min/max value is tracked even if 0. Then, when we'll aggregate it on the server side, I will filter out zero values. The reason why I'm also tracking the value of 0 is because the usage statistics currently don't easily allow to conditionally track a value.
Which issue(s) this PR fixes or relates to
Part of #1815
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]