Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration options deprecated in 2.2 #3111

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Oct 3, 2022

What this PR does

In this PR I'm removing configuration options we deprecated in 2.2 and announced they would have been removed in 2.4.

I will rebase after #3110 is merged.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci requested a review from a team as a code owner October 3, 2022 12:55
@pracucci pracucci mentioned this pull request Oct 3, 2022
45 tasks
@pstibrany
Copy link
Member

Feel free to close my duplicate PR and keep only this one.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the change to mimirtool too

CHANGELOG.md Outdated Show resolved Hide resolved
pracucci and others added 2 commits October 4, 2022 09:53
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@pracucci pracucci force-pushed the remove-deprecated-features branch from 41c0738 to 8a71cc3 Compare October 4, 2022 07:53
@@ -12,8 +12,10 @@
* [CHANGE] Anonymous usage statistics tracking: added the minimum and maximum value of `-ingester.out-of-order-time-window`. #2940
* [CHANGE] The default hash ring heartbeat period for distributors, ingesters, rulers and compactors has been increased from `5s` to `15s`. Now the default heartbeat period for all Mimir hash rings is `15s`. #3033
* [CHANGE] Reduce the default TSDB head compaction concurrency (`-blocks-storage.tsdb.head-compaction-concurrency`) from 5 to 1, in order to reduce CPU spikes. #3093
* [CHANGE] Previously deprecated `active_series_custom_trackers_config` has been removed. #3110
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased below.

@pracucci pracucci enabled auto-merge (squash) October 4, 2022 07:54
@pracucci pracucci merged commit 6ebce3c into main Oct 4, 2022
@pracucci pracucci deleted the remove-deprecated-features branch October 4, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants