Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin: Compile and archive for barematal deployment #3162

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

wilfriedroset
Copy link
Collaborator

What this PR does

Compile and archive for barematal deployment, along the k8s deployment.
This add ease for users not running mimir in k8s. Loki does something similar for the SSD deployment: https://github.com/grafana/loki/tree/main/production/loki-mixin-compiled-ssd

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@wilfriedroset wilfriedroset requested a review from a team as a code owner October 7, 2022 11:53
@wilfriedroset wilfriedroset force-pushed the mixin-baremetal branch 7 times, most recently from 6eb6b9d to b7ec7f5 Compare October 11, 2022 19:35
@wilfriedroset
Copy link
Collaborator Author

This PR will probably need to be rebased after the merge of #3196

wilfriedroset and others added 4 commits November 23, 2022 14:29
Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job, thanks! I hope you don't mind I rebased main and pushed a couple of commits to (a) remove the .zip (we git ignore the K8S one too) and (b) remove operations/mimir-mixin/mixin-baremetal.libsonnet because unused.

@pracucci pracucci enabled auto-merge (squash) November 23, 2022 13:37
@wilfriedroset
Copy link
Collaborator Author

All good for on my end.

@pracucci pracucci merged commit 854bcae into grafana:main Nov 23, 2022
masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
* Mixin: Compile and archive for barematal deployment

Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>

* Removed operations/mimir-mixin-baremetal.zip

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Rebased main

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Removed operations/mimir-mixin/mixin-baremetal.libsonnet because unused

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants