-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert MaxTime to seconds when recording compactor lag #3429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easy to add a check for this metric into some test? Exact numbers may be tricky, but at least verifying that "sum" is within expected range would be nice.
I can split the logic into a method and test that separately instead of adding to an existing test. WDYT? |
Fixes an issue where a timestamp in milliseconds was subtracted from a timestamp in seconds, resulting in negative deltas being recorded instead of the actual delay between the block maxtime and "now". Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
b580257
to
85a5d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for fixing reported seconds instead of millis.
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes an issue where a timestamp in milliseconds was subtracted from a timestamp in seconds, resulting in negative deltas being recorded instead of the actual delay between the block maxtime and "now". Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
What this PR does
Fixes an issue where a timestamp in milliseconds was subtracted from a timestamp in seconds, resulting in negative deltas being recorded instead of the actual delay between the block maxtime and "now".
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]