-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide TSDB block ranges period config from doc and mark it experimental #3518
Conversation
💯 Agree. If it wasn't a breaking change, I'd remove the option as well. |
I think hiding it is one possible solution, although it could be interpreted as a bug in the docs... I just wanted to propose one potential alternative solution which doesn't require hiding it which I already mentioned when we met recently: We could add an |
+1 I'm always in favor of less configuration to worry about. To fix the high disk utilization use case, I'd rather we shipped blocks at 80% disk capacity (or two hours, whichever comes first) . And if we don't test something , then it doesn't exists, so we should make the current option unsafe or remove it. |
This is sometimes a strategy to force a happy path, and at other times it is indicative of a deeper issue. Documentation is a tool of discovery in this case. How close can we fix x at its core? I will not block this PR whatever you all decide, but encourage a more root-cause fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking and leaning on engineering to make a decision wrt ease of use
Do any of these references need to be updated or removed: https://github.com/grafana/mimir/search?l=Markdown&q=TSDB+block+ranges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
23d271d
to
40a4dd4
Compare
Good point @osg-grafana ! I spot this: 40a4dd4 |
Merging until we have a better way to deal with it (see #3528). |
#3518) * Hide TSDB block ranges period config from doc and mark it experimental Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove CLI flag mention from Helm migration doc Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
#3518) * Hide TSDB block ranges period config from doc and mark it experimental Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove CLI flag mention from Helm migration doc Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 56b6e35)
#3518) (#3575) * Hide TSDB block ranges period config from doc and mark it experimental Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove CLI flag mention from Helm migration doc Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 56b6e35) Co-authored-by: Marco Pracucci <marco@pracucci.com>
grafana#3518) * Hide TSDB block ranges period config from doc and mark it experimental Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove CLI flag mention from Helm migration doc Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
…erimental (grafana#3518)" This reverts commit 54344f2.
grafana#3518) (grafana#3575) * Hide TSDB block ranges period config from doc and mark it experimental Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove CLI flag mention from Helm migration doc Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 56b6e35) Co-authored-by: Marco Pracucci <marco@pracucci.com>
What this PR does
From time to time I see some people from OSS community changing TSDB block ranges period. I think we're not ready for that, given whenever we design features and default config we only think about the TSDB 2h block ranges period. This option was configurable only for testing purposes (e.g. we use it in integration tests) but in my opinion shouldn't be changed (at least I would love that we officially not support any value different than 2h).
For this reason, I'm proposing to hide it from the doc.
I know this PR is controversial, but I genuinely believe that doing so we do a step forward to help OSS community not shooting to their feet (cause if you change it you need to understand how things work internally and which other config options to change accordingly).
Thoughts?
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]