Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP do not pick: Vendor weaworks/common branch #3524

Closed
wants to merge 4 commits into from

Conversation

krajorama
Copy link
Contributor

What this PR does

Testing new weaworks/common versions

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@krajorama krajorama requested a review from a team as a code owner November 25, 2022 09:22
@krajorama krajorama marked this pull request as draft November 25, 2022 09:22
@krajorama krajorama force-pushed the krajo/20221124-test-new-weaworks branch 2 times, most recently from c382dd9 to d89f35e Compare November 28, 2022 08:30
@replay
Copy link
Contributor

replay commented Nov 29, 2022

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

To be compatible with prometheus 2.40.x

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
New weaveworks common explicitly includes gogo protobuf on a more
generic location.
See weaveworks/common#265

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
TLSStruct was renamed to TLSConfig

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama
Copy link
Contributor Author

weaveworks/common change was pushed and downstream projects took on the changes. No need for the test PR anymore

@krajorama krajorama closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants