Refactoring: simplified dashboards resources and networking panels utilities #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilities Signed-off-by: Marco Pracucci <marco@pracucci.com>
replay
pushed a commit
that referenced
this pull request
Nov 28, 2022
…ilities (#3531) Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3531-to-release-2.5 origin/release-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b0a390ba2d830c83c28f9dcf4d0740f77ed625cf
# Push it to GitHub
git push --set-upstream origin backport-3531-to-release-2.5
git switch main
# Remove the local backport branch
git branch -D backport-3531-to-release-2.5Then, create a pull request where the |
|
I think the reason why the backport via grafanabot failed is because this PR isn't merged into I'll remove the |
replay
added
backport release-2.5
and removed
backport release-2.5
backport-failed
labels
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…ilities (grafana#3531) Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…anels utilities (grafana#3531)" This reverts commit 62370a6.
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…ilities (grafana#3531) (grafana#3578) Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit b0a390b) Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is a dashboards refactoring PR, with no diff in the compiled dashboards. I'm introducing some utillities to build resources and networking panels based on the component name (all such functions are suffixed with
ByComponentfor clarity).Which issue(s) this PR fixes or relates to
Part of #3361
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]