Tag all activity-tracker logs #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be quite hard to find all the activity-tracker logs, I usually grep by `activity` but some customers have that in many queries that are being logged too. Grepping by `activity=` could do the trick sometimes, but also not always. This adds a `module=activity-tracker` label to all the logs issues for the activity tracker, making it much easier to find them. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
approved these changes
Nov 29, 2022
Co-authored-by: Marco Pracucci <marco@pracucci.com>
colega
commented
Nov 29, 2022
pstibrany
approved these changes
Nov 29, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
* Tag all activity-tracker logs It can be quite hard to find all the activity-tracker logs, I usually grep by `activity` but some customers have that in many queries that are being logged too. Grepping by `activity=` could do the trick sometimes, but also not always. This adds a `module=activity-tracker` label to all the logs issues for the activity tracker, making it much easier to find them. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update pkg/mimir/modules.go Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
It can be quite hard to find all the activity-tracker logs, I usually grep by
activitybut some customers have that in many queries that are being logged too. Grepping byactivity=could do the trick sometimes, but also not always.This adds a
module=activity-trackerlabel to all the logs issues for the activity tracker, making it much easier to find them.Which issue(s) this PR fixes or relates to
None
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]