Streaming store-gateway: add structs and interfaces for sets of series #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first PR in which we are introducing code related to the streaming implementation of the store-gateway. This PR introduces two prod files and two test files. - `series_refs.go` contains structs and interfaces for holding and iterating over a set of series which still doesn't have chunks yet. It only contains refs to chunks and labels. - `series_chunks.go`, in turn, contains structs and interfaces for representing and iterating over a set of series which has its labels _and_ chunks loaded. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
|
We're merging it. If you have any post-merge comments, we'll promptly address them. |
This was referenced Dec 1, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
grafana#3587) * Streaming store-gateway: add structs and interfaces for sets of series This is the first PR in which we are introducing code related to the streaming implementation of the store-gateway. This PR introduces two prod files and two test files. - `series_refs.go` contains structs and interfaces for holding and iterating over a set of series which still doesn't have chunks yet. It only contains refs to chunks and labels. - `series_chunks.go`, in turn, contains structs and interfaces for representing and iterating over a set of series which has its labels _and_ chunks loaded. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update pkg/storegateway/series_chunks.go Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in which we are introducing code related to the
streaming implementation of the store-gateway.
This PR introduces two prod files and two test files.
series_refs.gocontains structs and interfaces for holding anditerating over a set of series which still doesn't have chunks yet.
It only contains refs to chunks and labels.
series_chunks.go, in turn, contains structs and interfaces forrepresenting and iterating over a set of series which has its labels
and chunks loaded.
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com
Co-authored-by: Marco Pracucci marco@pracucci.com