Add default "time" param to parsed form (if any) #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the form was already parsed by a downstream middleware, we need to add it to that form too, otherwise it won't be available to upstream by just adding it to the url query. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
3 tasks
pstibrany
approved these changes
Dec 1, 2022
| r.URL.RawQuery = q.Encode() | ||
|
|
||
| // If form was already parsed, add this param to the form too. |
There was a problem hiding this comment.
We should also mention that if form already had time parameter, this extra time value will be ignored.
There was a problem hiding this comment.
What I did was to add back the r.Form.Has("time") guard in this method, as otherwise we were adding the "time" to the form even if it already had it.
It only worked because I used the "Add" method, which added another value, and the old value was still being read.
Changed this and added a test case for that: a69fb16
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
pushed a commit
that referenced
this pull request
Dec 1, 2022
* Add default "time" param to parsed form (if any) If the form was already parsed by a downstream middleware, we need to add it to that form too, otherwise it won't be available to upstream by just adding it to the url query. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Check that form doesn't have "time" Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
* Add default "time" param to parsed form (if any) If the form was already parsed by a downstream middleware, we need to add it to that form too, otherwise it won't be available to upstream by just adding it to the url query. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Check that form doesn't have "time" Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
If the form was already parsed by a downstream middleware, we need to add it to that form too, otherwise it won't be available to upstream by just adding it to the url query.
This implement's @pstibrany's suggestion #3588 (comment) and copies all the tests from that PR.
Which issue(s) this PR fixes or relates to
Will make #3561 easier to review.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]