Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "unsupported value type" logged when calling /ready and some services are not yet running. #3625

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Fix "unsupported value type" logged when calling /ready and some services are not yet running. #3625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e810081
Fix "unsupported value type" logged when calling /ready and some serv…
charleskorn Dec 2, 2022
ab18718
Add changelog entry.
charleskorn Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* [ENHANCEMENT] Ruler: Added `-ruler.alertmanager-client.tls-enabled` configuration for alertmanager client. #3432 #3597
* [ENHANCEMENT] Activity tracker logs now have `component=activity-tracker` label. #3556
* [BUGFIX] Log the names of services that are not yet running rather than `unsupported value type` when calling `/ready` and some services are not running. #3625

## 2.5.0-rc.0

Expand Down
2 changes: 1 addition & 1 deletion pkg/mimir/mimir.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ func (t *Mimir) readyHandler(sm *services.Manager, shutdownRequested *atomic.Boo
}
}

level.Debug(util_log.Logger).Log("msg", "some services are not Running", "services", serviceNamesStates)
level.Debug(util_log.Logger).Log("msg", "some services are not Running", "services", strings.Join(serviceNamesStates, ", "))
httpResponse := "Some services are not Running:\n" + strings.Join(serviceNamesStates, "\n")
http.Error(w, httpResponse, http.StatusServiceUnavailable)
return
Expand Down