Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruler: change deployment max surge and max unavailable to reduce ownership spillover #4381

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Ruler: change deployment max surge and max unavailable to reduce ownership spillover #4381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e6c850
Ruler: change deployment max surge and max unavailable to reduce owne…
pracucci Mar 6, 2023
5a21fa8
Apply suggestions from code review
pracucci Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Querying with using `{__mimir_storage__="ephemeral"}` selector no longer works.

* [CHANGE] Create the `query-frontend-discovery` service only when Mimir is deployed in microservice mode without query-scheduler. #4353
* [CHANGE] Add results cache backend config to `ruler-query-frontend` configuration to allow cache reuse for cardinality-estimation based sharding. #4257
* [CHANGE] Ruler: changed ruler deployment max surge from `0` to `50%`, and max unavailable from `1` to `0`. #4381
* [ENHANCEMENT] Add support for ruler auto-scaling. #4046
* [ENHANCEMENT] Add optional `weight` param to `newQuerierScaledObject` and `newRulerQuerierScaledObject` to allow running multiple querier deployments on different node types. #4141
* [ENHANCEMENT] Add support for query-frontend and ruler-query-frontend auto-scaling. #4199
Expand Down
1 change: 1 addition & 0 deletions operations/helm/charts/mimir-distributed/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Entries should include a reference to the Pull Request that introduced the chang

## main / unreleased

* [CHANGE] Ruler: changed ruler deployment max surge from `0` to `50%`, and max unavailable from `1` to `0`. #4381
* [ENHANCEMENT] Support autoscaling/v2 HorizontalPodAutoscaler for nginx autoscaling starting with Kubernetes 1.23. #4285
* [BUGFIX] Allow override of Kubernetes version for nginx HPA. #4299
* [BUGFIX] Do not generate query-frontend-headless service if query scheduler is enabled. Fixes parity with jsonnet. #4353
Expand Down
4 changes: 2 additions & 2 deletions operations/helm/charts/mimir-distributed/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,8 +1015,8 @@ ruler:
strategy:
type: RollingUpdate
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0

terminationGracePeriodSeconds: 180

Expand Down
4 changes: 2 additions & 2 deletions ...ests/gateway-enterprise-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...elm/tests/gateway-nginx-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions .../tests/graphite-enabled-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...ations/helm/tests/large-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...lm/tests/metamonitoring-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...lm/tests/scheduler-name-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...ations/helm/tests/small-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...st-enterprise-configmap-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...est-enterprise-k8s-1.25-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...enterprise-legacy-label-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ spec:
release: test-enterprise-legacy-label-values
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...m/tests/test-enterprise-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...tests/test-oss-k8s-1.25-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...t-oss-logical-multizone-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...ests/test-oss-multizone-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions ...ons/helm/tests/test-oss-values-generated/mimir-distributed/templates/ruler/ruler-dep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ spec:
app.kubernetes.io/component: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
type: RollingUpdate
template:
metadata:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-autoscaling-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,8 +750,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-consul-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,8 +1042,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-consul-multi-zone-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,8 +1240,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-deployment-mode-migration-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,8 +1269,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-disable-chunk-streaming-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-extra-runtime-config-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,8 +703,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-helm-parity-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-cluster-label-migration-step-0-before-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-cluster-label-migration-step-1-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,8 +677,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-cluster-label-migration-step-2-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,8 +679,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-cluster-label-migration-step-3-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,8 +677,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-migration-step-0-before-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,8 +1042,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-migration-step-1-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,8 +1096,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-migration-step-2-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,8 +1096,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-migration-step-3-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,8 +1096,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-migration-step-4-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,8 +1096,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-migration-step-5-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-memberlist-migration-step-6-final-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,8 @@ spec:
name: ruler
strategy:
rollingUpdate:
maxSurge: 0
maxUnavailable: 1
maxSurge: 50%
maxUnavailable: 0
template:
metadata:
labels:
Expand Down
Loading