Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native histograms support in querier remote read #4425

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

leizor
Copy link
Contributor

@leizor leizor commented Mar 8, 2023

What this PR does

Enables Mimir's Prometheus remote read compatible API
https://grafana.com/docs/mimir/latest/operators-guide/reference-http-api/#remote-read
to return native histogram samples.

Which issue(s) this PR fixes or relates to

Related to #3478

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
@leizor leizor marked this pull request as ready for review March 8, 2023 18:29
@leizor leizor requested a review from a team as a code owner March 8, 2023 18:29
@pstibrany
Copy link
Member

PR description is empty, can you please update it?

CHANGELOG.md Outdated Show resolved Hide resolved
krajorama added a commit that referenced this pull request Mar 9, 2023
Went to #4425

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama mentioned this pull request Mar 9, 2023
3 tasks
@pstibrany
Copy link
Member

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a couple of nits).

pkg/querier/remote_read.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krajorama krajorama enabled auto-merge (squash) March 9, 2023 12:48
@krajorama krajorama disabled auto-merge March 9, 2023 12:55
@krajorama krajorama enabled auto-merge (squash) March 9, 2023 12:56
@krajorama krajorama merged commit 1e26275 into main Mar 9, 2023
@krajorama krajorama deleted the leizor/nh-remote-read-to-main branch March 9, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants