Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored mimir-prometheus #4432

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Mar 9, 2023

What this PR does

Updating the vendored mimir-prometheus to get two changes:

  1. Optimize regex star operation mimir-prometheus#448
  2. Rules: Increase tolerance for missed iterations on alerts mimir-prometheus#447

Which issue(s) this PR fixes or relates to

Fixes #4118

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci requested a review from a team as a code owner March 9, 2023 08:52
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pracucci pracucci force-pushed the update-vendored-mimir-prometheus branch from 66e6c4d to 1c4446c Compare March 9, 2023 09:05
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the update-vendored-mimir-prometheus branch from 1c4446c to e9ea9bc Compare March 9, 2023 09:07
@pstibrany
Copy link
Member

The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG document. Thanks!

@pracucci pracucci merged commit 2c69615 into main Mar 9, 2023
@pracucci pracucci deleted the update-vendored-mimir-prometheus branch March 9, 2023 09:42
osg-grafana pushed a commit that referenced this pull request Mar 9, 2023
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruler: increase tolerance for missed iterations on alerts
4 participants