Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable ring health check in the readiness endpoint #48

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Aug 2, 2021

What this PR does:
We're rolling out ingesters in multiple zones. When we do it, multiple ingesters in the same zone can be rolled out simultaneously but their readiness endpoint will not succeed until all ingesters in the ring are ACTIVE and healthy.

In this PR I'm proposing to add an option to disable this check.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested review from pstibrany and bboreham August 2, 2021 13:11
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@pracucci pracucci merged commit 2dd9f6c into main Aug 3, 2021
@pracucci pracucci deleted the allow-to-disable-readiness-check-ring-healthy branch August 3, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants