Allow to specify -prometheus-http-prefix for mimirtool analyze prometheus #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfriedroset
force-pushed
the
mimirtool-prometheus-http-prefix
branch
from
b8c80f8
to
876be9a
Compare
…heus When configuring mimirtool via environment variables users might use the following: ``` MIMIR_ADDRESS=https://mimir:9090 MIMIR_TENANT_ID=default MIMIR_API_USER=default MIMIR_API_KEY=1234 ``` It works as expected for `mimirtool analyze ruler` but not for `mimirtool analyze prometheus`. The HTTP client for `analyze ruler` is done with `github.com/grafana/mimir/pkg/mimirtool/client`, when for `analyze prometheus` it is done with only the address. Depending on which prometheus the user wants to analyze the path is not the same. For a mimir based analysis user needs to provide `/prometheus`. This commit allow to specify the path to use for a mimir based analysis. It also simplify the scripting around the tool. Example: ``` source .secrets.env mimirtool analyze grafana && \ mimirtool analyze ruler && \ mimirtool analyze prometheus --prometheus-http-prefix="/prometheus" ``` Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
wilfriedroset
force-pushed
the
mimirtool-prometheus-http-prefix
branch
from
876be9a
to
794e427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When configuring mimirtool via environment variables users might use the following:
It works as expected for
mimirtool analyze rulerbut not formimirtool analyze prometheus.The HTTP client for
analyze ruleris done withgithub.com/grafana/mimir/pkg/mimirtool/client, when foranalyze prometheusit is done with only the address.Depending on which prometheus the user wants to analyze the path is not the same. For a mimir based analysis user needs to provide
/prometheus.This commit allow to specify the path to use for a mimir based analysis. It also simplify the scripting around the tool.
Example:
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]