store-gateway: record index header loading times separately #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the time to load an index can either be attributed to loading `expand_postings` or to `fetch_series_and_chunks`. This depends on which stage needed to read the index header first (posting lists vs symbols). This makes it harder to tell whether there's something in either of those two stages which increases latency or it's the index header. This PR forces to load an index header upon opening a `bucketIndexReader`. Then records this time in a new stage in `cortex_bucket_store_series_request_stage_duration_seconds` - `load_index`. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
approved these changes
May 15, 2023
dimitarvdimitrov
deleted the
dimitar/st-gw/record-index-header-loading-separately
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently, the time to load an index can either be attributed to loading
expand_postingsor tofetch_series_and_chunks. This depends on which stage needed to read the index header first (posting lists vs symbols). This makes it harder to tell whether there's something in either of those two stages which increases latency or it's the index header.This PR forces to load an index header upon opening a
bucketIndexReader. Then records this time in a new stage incortex_bucket_store_series_request_stage_duration_seconds-load_index.Which issue(s) this PR fixes or relates to
Fixes #4881
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]