Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show cancelled requests in grey in throughput panels on dashboards #5039

Merged
merged 2 commits into from
May 18, 2023
Merged

Show cancelled requests in grey in throughput panels on dashboards #5039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ebbec
Update jsonnet-libs
charleskorn May 18, 2023
28ec890
Add changelog entry
charleskorn May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
* [ENHANCEMENT] Alerts: added labels to duplicated `MimirRolloutStuck` and `MimirCompactorHasNotUploadedBlocks` rules in order to distinguish them. #5023
* [ENHANCEMENT] Dashboards: fix holes in graph for lightly loaded clusters #4915
* [ENHANCEMENT] Dashboards: allow configuring additional services for the Rollout Progress dashboard. #5007
* [BUGFIX] Dashboards: show cancelled requests in a different color to successful requests in throughput panels on dashboards. #5039

### Jsonnet

Expand Down
21 changes: 21 additions & 0 deletions ...oring-values-generated/mimir-distributed/templates/metamonitoring/grafana-dashboards.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,6 +1161,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -6648,6 +6649,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -11231,6 +11233,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -11514,6 +11517,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -21125,6 +21129,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -21375,6 +21380,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -21743,6 +21749,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -21982,6 +21989,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -22221,6 +22229,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -22726,6 +22735,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -26615,6 +26625,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -26854,6 +26865,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -27042,6 +27054,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -29642,6 +29655,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -29830,6 +29844,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -30018,6 +30033,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -39702,6 +39718,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -39941,6 +39958,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -40518,6 +40536,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -40706,6 +40725,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -40894,6 +40914,7 @@ data:
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-alertmanager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-compactor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2031,6 +2031,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
2 changes: 2 additions & 0 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-overview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -463,6 +464,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
6 changes: 6 additions & 0 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-reads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -711,6 +712,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -1079,6 +1081,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -1318,6 +1321,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -1557,6 +1561,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -2062,6 +2067,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
3 changes: 3 additions & 0 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-remote-ruler-reads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -392,6 +393,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -580,6 +582,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
3 changes: 3 additions & 0 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-ruler.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -729,6 +730,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -917,6 +919,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
5 changes: 5 additions & 0 deletions operations/mimir-mixin-compiled-baremetal/dashboards/mimir-writes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -698,6 +699,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -1275,6 +1277,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -1463,6 +1466,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -1651,6 +1655,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-mixin-compiled/dashboards/mimir-alertmanager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
1 change: 1 addition & 0 deletions operations/mimir-mixin-compiled/dashboards/mimir-compactor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2031,6 +2031,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
2 changes: 2 additions & 0 deletions operations/mimir-mixin-compiled/dashboards/mimir-overview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down Expand Up @@ -463,6 +464,7 @@
"3xx": "#6ED0E0",
"4xx": "#EF843C",
"5xx": "#E24D42",
"cancel": "#A9A9A9",
"error": "#E24D42",
"success": "#7EB26D"
},
Expand Down
Loading