Ruler: add configuration option to disable event-based sync #5053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to have this flag per tenant, so that we can avoid syncing rules when a tenant performs API change and only do it via regular (time-based) sync? |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
ruler-option-to-disable-event-based-sync
branch
from
e76ee79
to
ca53d31
Compare
Makes sense. Done in ca53d31. |
pracucci
force-pushed
the
ruler-option-to-disable-event-based-sync
branch
from
ca53d31
to
7005002
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
ruler-option-to-disable-event-based-sync
branch
from
7005002
to
edd5196
Compare
gotjosh
approved these changes
May 24, 2023
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The event-based rule groups re-sync introduced in #4975 is expected to benefit Mimir clusters with a large number of tenants, not updating rule groups frequently. However, there are some cases where a single-tenant Mimir cluster may get rule groups re-uploaded very frequently and so the event-based re-sync may actually increase the cost instead of decreasing it.
In this PR I'm simply introducing an answer to disable it, while keeping it enabled by default. To do it, I've took the simplest path: do not put the request to the outbound queue when the event-based sync is disabled. The queue and queue processor are started anyway, but they're not expected to make any dent in terms of resources utilization given they're not going to be used.
Which issue(s) this PR fixes or relates to
Part of #4941.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]