Update dskit #5161
Merged
Update dskit #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/dskit-upgrade
branch
2 times, most recently
from
9a2a2cb
to
2bb949a
Compare
charleskorn
force-pushed
the
charleskorn/dskit-upgrade
branch
from
0e766f3
to
0937583
Compare
3 tasks
pracucci
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
LGTM. I double checked the code changes in Mimir and dskit.
I also checked the release notes for grpc and I can't see anything we should handle:
google.golang.org/grpc v1.53.0
google.golang.org/grpc v1.55.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates dskit to the latest version.
It includes the following notable PRs:
DoUntilQuorumto optionally only send the minimum number of requests required to reach quorum dskit#306Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]