Honor -querier.minimize-ingester-requests configuration in the cardinality queries too #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ality queries too Signed-off-by: Marco Pracucci <marco@pracucci.com>
charleskorn
approved these changes
Jun 15, 2023
pracucci
deleted the
honor-minimize-requests-for-cardinality-api-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
#5202 introduced the option
-querier.minimize-ingester-requests(default false) to minimize requests to ingesters. The subsequent PR #5136 used the "minimize requests" code for the cardinality queries and enabled it (hardcoded). I think would be better if we honor-querier.minimize-ingester-requestsin the cardinality queries too, which is what I'm proposing in this PR.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]