UtilizationBasedLimiter: Get wall time after CPU time #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/utilization-limiter-now-after
branch
from
68cba95
to
fce80a0
Compare
jhalterman
approved these changes
Jul 17, 2023
pracucci
approved these changes
Jul 17, 2023
grafanabot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> (cherry picked from commit 07f689c)
aknuds1
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Change
pkg/util/limiter.UtilizationBasedLimiterto get current wall time after CPU time. My thinking is that if extracting the CPU time from /proc would be somehow delayed, the calculated CPU utilization would be too high (on account of elapsed wall time being too short vs. elapsed CPU time).Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]